The confusion of puts()

kamioo

#include<stdio.h>
char *read(char *p,int n);
int main(void)
{
char s[10];
char *p;
int q;
p=read(s,10);
   return 0;
}

char *read(char *p,int n)
{
int m=n;
   
while(n--)
{p[m-n]=getchar();
printf ("%c",p[m-n]);}//print 1
printf ("\n");
puts(p);//print 2

          return p;
}
For such a function, there is no problem with printing 1 sentence, why is there a problem with puts(), and it displays garbled characters? Does puts() must be used with gets()?

zhoudaj

C stipulates that the end of the string is '\0', and all the elements of the string array in your program are characters input by getchar. If the system cannot find '\0', it will consider the string to be unfinished, so there is Garbled. You can check whether the first few characters of garbled are correct.

orangedj

memset(s, 0, sizeof(s)) before read();

soloxx

Will it work?
#include<stdio.h>
#include<stdlib.h>
char *read(char *p,int n);
int main(void)
{
char s[10];
char *p;
// int q;
p=read(s,10);
puts(p);
         printf ("\n");
         system( "pause" );
         return 0;
}

char *read(char *p,int n)
{
// int m=n;
         char *q=p;
while(n--)
{
// p[m-n]=getchar();
*p = getchar();
p++;
// printf ("%c",p[m-n]); //print 1
}
*p = '\0';
// puts(p);
// printf ("\n");
// puts(p); //print 2

   return q;
}

zhoudaj

No, p is the first address of the array, how can you make p just ++?
As long as in your first program, let p[9] = '\0' in the read function.

soloxx

No, p is the first address of the array, how can you make p just ++?
_______________________________________________________________
See it clearly..

As long as in your first program, let p[9] = '\0' in the read function.
________________________________________________________________
Run first and enter 10 characters to see the result..

kamioo

#include<stdio.h>
char *read(char *p,int n);
int main(void)
{
char s[11];
s[10]='\0';//My LCC does not support direct definition. . trouble. .
           //PS: I think undefined is a null character. . Mistaken. . Sorry
char *p;
p=read(s,10);
puts(p);
   return 0;
}

char *read(char *p,int n)
{
int m=n;

while(n--)
{p[m-n-1]=getchar();}//It should be m-n-1
     //printf ("%c",p[m-n]);}//print 1
//printf ("\n");
//puts(p);//print 2

          return p;
}
Two errors. . The modification is OK. .
Thank you all